Re[2]: [Gc] Patch resubmission: GC_do_blocking for Win32 and anti-GC_do_blocking

Ivan Maidanski ivmai at mail.ru
Tue Dec 8 02:33:39 PST 2009


Hi!
"Boehm, Hans" <hans.boehm at hp.com> wrote:
> I was very belatedly looking at this, and I have some minor concerns:
> 
> 1) As far as I can tell, when the code says "activation frame", it really means "traced stack section".  I found that confusing, when I started reading the code without the patch documentation, since a struct GC_activation_frame_s isn't really a single frame.  I think it would be good to consistently rename this, e.g. to traced_section.

Yes, I don't think "activation frame" (covering a group of adjacent stack frames) is good here neither (nor "non-[do-]blocking something" term). I change it to traced_stack_sect.

> ...

Bye.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bdwgc-ivmai-220.diff
Type: application/octet-stream
Size: 19924 bytes
Desc: not available
Url : http://napali.hpl.hp.com/pipermail/gc/attachments/20091208/95f9804f/bdwgc-ivmai-220-0001.obj


More information about the Gc mailing list