[Gc] Some minor fixes for test.c

Boehm, Hans hans.boehm at hp.com
Tue Feb 24 14:46:11 PST 2009


Committed, except for the commenting out of "FAIL".  I think I'd rather see spurious failures here than unwarranted passes.

Hans 

> -----Original Message-----
> From: gc-bounces at napali.hpl.hp.com 
> [mailto:gc-bounces at napali.hpl.hp.com] On Behalf Of Ivan Maidanski
> Sent: Saturday, October 25, 2008 11:39 AM
> To: gc at napali.hpl.hp.com
> Subject: [Gc] Some minor fixes for test.c
> 
> Hi!
> 
> This patch does some code polishing in test.c:
> - adjusts actual parameter type according to format specifier 
> for GC_printf() calls;
> - removes "unused result of expression" for 
> GC_PRE/POST_INCR/DECR() invocations (by casting to "void" type);
> - casts some values to GC_word (or size_t) to prevent 
> overflow or compiler warning (useful for Win64);
> - comments out "FAIL" (at least, temporarily) on "Unexpected 
> heap growth" (since its trigging condition seems to be wrong 
> - e.g. in Win32 with THREAD_LOCAL_ALLOC+PARALLEL_MARK the 
> condition is violated frequently).
> 
> Bye.
> 
> 


More information about the Gc mailing list