Re[2]: [Gc] Figured out my problem with finalization cycles. Usefulpatchattached.

Ivan Maidanski ivmai at mail.ru
Fri Jun 5 07:26:31 PDT 2009


Hi!

"Talbot, George" <Gtalbot at locuspharma.com> wrote:
> Hi,
> 
> Ivan, thanks for looking at the patch.
> 
> Ok.  This version of the patch fixes the issue identified by Ivan where AO_fetch_and_add1() isn't available by reverting to the previous behavior on such a platform.

Small tip for the patch: it's good to inc indentation level inside #if-else-endif.

> 
> What would I need to do to GC_print_backtrace() to have it detect pointer cycles while it's printing; note that at the point when GC_finalize() is calling it, GC_finalize() appears to be marking to find cycles involving finalizeable items.

IMHO, GC_print_backtrace() should be fixed to prevent infinite printing. I think, a nested loop would do (since time doesn't matter here).

> This patch is current w.r.t. CVS as of ~9:15AM EST 6/5/2009.
> 
> Thanks.
> 
> --
> George T. Talbot
> <gtalbot at locuspharma.com>

Bye.


More information about the Gc mailing list