Re[6]: [Gc] Small patch to allow initial and maximum heapsizesto be>2GB.

Ivan Maidanski ivmai at mail.ru
Fri Jun 12 11:39:14 PDT 2009


Hi!

"Boehm, Hans" <hans.boehm at hp.com> wrote:
> Thanks.
> 
> Could you resubmit this with a few changes:
> 
> 1) # if indentation should be consistent with the rest of the code.  (Preprocessor commands should be on their own line, "#" in column 1, the rest indented appropriately.)
> 
> 2) Please use ULLONG_MAX instead of the magic constant.  Actually, it appears that _UI64_MAX plays a similar role on Windows?  Both no doubt require limits.h.
> 
> 3) Could you attach some form of context diff (e.g. -u) instead of inligning it?  The inlined version tends to get mangled by mailers.  The no-context versions are a bit dangerous to apply.
> 
> Hans

I've refined this patch, see this one (diff95_cvs) as a final solution:
http://article.gmane.org/gmane.comp.programming.garbage-collection.boehmgc/2799 

>> ...

Bye.



More information about the Gc mailing list