[Gc] Small patch to allow initial and maximum
hans.boehm at hp.com
Fri Jun 12 12:01:00 PDT 2009
Thanks. I thought I was missing a message. I committed diff95_cvs from the gmane repository, so this issue should now be settled.
> -----Original Message-----
> From: gc-bounces at napali.hpl.hp.com
> [mailto:gc-bounces at napali.hpl.hp.com] On Behalf Of Ivan Maidanski
> Sent: Friday, June 12, 2009 11:39 AM
> To: gc at napali.hpl.hp.com
> Subject: Re: [Gc] Small patch to allow initial and maximum
> heapsizesto be>2GB.
> "Boehm, Hans" <hans.boehm at hp.com> wrote:
> > Thanks.
> > Could you resubmit this with a few changes:
> > 1) # if indentation should be consistent with the rest of
> the code.
> > (Preprocessor commands should be on their own line, "#" in
> column 1,
> > the rest indented appropriately.)
> > 2) Please use ULLONG_MAX instead of the magic constant.
> Actually, it appears that _UI64_MAX plays a similar role on
> Windows? Both no doubt require limits.h.
> > 3) Could you attach some form of context diff (e.g. -u)
> instead of inligning it? The inlined version tends to get
> mangled by mailers. The no-context versions are a bit
> dangerous to apply.
> > Hans
> I've refined this patch, see this one (diff95_cvs) as a final
> >> ...
> Gc mailing list
> Gc at linux.hpl.hp.com
More information about the Gc