[Gc] GC 7.2alpha2

Petter Urkedal urkedal at nbi.dk
Sun Jun 14 02:21:07 PDT 2009


On 2009-06-13, Ivan Maidanski wrote:
> Missing files in the tar ball:
> - tests/trace_test.c,

Yes, it's commented out in tests/tests.am, so it should probably also be
taken out of Makefile.direct or added to EXTRA_DIST.

However, it appears to me that GC_generate_random_backtrace is only
emitted if KEEP_BACK_PTRS is defined, which means when configured with
--enable-gc-debug, so is it possible this issue was not Mac OS X 10.3
specific?  The attached patch makes the tests/trace_test.c test
conditioned on --enable-gc-debug.  Can someone test on Mac OS X 10.3?

> - Makefile,

Makefile is created from Makefile.in by configure.  I contains
substitutions and some conditional sections which are only known after
configure is run, so Makefile should not end up in the tarball.

> - autogen.sh,

It's usually not needed by end users, but might be used in some cases if
e.g.  patches are applied after extracting the tarball.  Nevertheless
this is mostly equivalent to "autoreconf -vif", so I think it could be
removed completely.  Before doing so, I'd suggest also removing
"libtool.m4", since it's outdated and cause a lot of noise on newer
Automake.

> Missing file in CVS:
> - bdw-gc.pc

The problem is rather its presence in the tarball.  The function of this
file is to hold information about the local installation.  configure
substitutes some installation directories into it.  So, I don't think it
makes sense to distribute it.  This change is include in the attachment.
-------------- next part --------------
diff --git a/Makefile.am b/Makefile.am
index fb658e2..2cb3b91 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -42,7 +42,7 @@ check_PROGRAMS =
 TESTS =
 
 pkgconfigdir = $(libdir)/pkgconfig
-dist_pkgconfig_DATA = bdw-gc.pc
+pkgconfig_DATA = bdw-gc.pc
 
 # C Library
 # ---------
diff --git a/configure.ac b/configure.ac
index 8bb800f..0e04cf4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -528,6 +528,7 @@ AC_ARG_ENABLE(gc-debug,
 [ if test "$enable_gc_debug" = "yes"; then
     AC_MSG_WARN("Should define GC_DEBUG and use debug alloc. in clients.")
     AC_DEFINE(KEEP_BACK_PTRS)
+    keep_back_ptrs=true
     AC_DEFINE(DBG_HDRS_ALL)
     case $host in
       ia64-*-linux* )
@@ -549,6 +550,7 @@ AC_ARG_ENABLE(gc-debug,
       ;;
     esac ]
   fi)
+AM_CONDITIONAL([KEEP_BACK_PTRS], [test x"$keep_back_ptrs" = xtrue])
 
 AC_ARG_ENABLE(java-finalization,
     [AC_HELP_STRING([--disable-java-finalization],
diff --git a/tests/tests.am b/tests/tests.am
index a9c0e73..9ad3c74 100644
--- a/tests/tests.am
+++ b/tests/tests.am
@@ -46,10 +46,12 @@ check_PROGRAMS += hugetest
 hugetest_SOURCES = tests/huge_test.c
 hugetest_LDADD = $(test_ldadd)
 
-#TESTS += tracetest$(EXEEXT)
-#check_PROGRAMS += tracetest
-#tracetest_SOURCES = tests/trace_test.c
-#tracetest_LDADD = $(test_ldadd)
+if KEEP_BACK_PTRS
+TESTS += tracetest$(EXEEXT)
+check_PROGRAMS += tracetest
+tracetest_SOURCES = tests/trace_test.c
+tracetest_LDADD = $(test_ldadd)
+endif
 
 if THREADS
 TESTS += threadleaktest$(EXEEXT)


More information about the Gc mailing list