[Gc] Dependency tracking for configuration macros
hans.boehm at hp.com
Fri May 22 16:43:07 PDT 2009
How about the following:
- I've committed Ivan's diff61, minus the gc.h includes, so that it's off the table.
- I'm not enthusiastic about the complicated include chain through gc.h. Could we include private/config.h from only private/gcconfig.h, and then include that, or gc_priv.h, in the places in which gc.h is being newly included, and possibly in any others it might be needed? That way this stays out of client visible headers, which I think is the right thing?
I think that would only involve a minor rebuild of the patch.
> -----Original Message-----
> From: gc-bounces at napali.hpl.hp.com
> [mailto:gc-bounces at napali.hpl.hp.com] On Behalf Of Petter Urkedal
> Sent: Thursday, May 21, 2009 10:02 AM
> To: gc at napali.hpl.hp.com
> Subject: Re: [Gc] Dependency tracking for configuration macros
> Attached is a slightly modified patch due to some of Ivan's
> Hans, please let me know if you have an opinion on Ivan's
> other points (esp his second email), or other suggestions.
> Dependency tracking for configuration macros:
> * configure.ac, acinclude.m4: Invoke AC_CONFIG_HEADER. Added
> documentation of configuration macros.
> * configure.ac, Makefile.am: Moved include paths to
> Makefile.am. Added include path for build directory.
> * include/gc_config_macros.h, include/private/gcconfig.h:
> Conditionally include "private/config.h".
> * include/gc.h, include/private/gc_pmark.h, backgraph.c,
> checksums.c, gcj_mlc.c, real_malloc.c, tests/test.c: Minor
> adjustments to make sure that the config macros are defined
> before use.
> * configure.ac: Removed the unused macros STACKBASE and
> * misc.c: Removed unused #undef STACKBASE.
More information about the Gc