[Gc] Dependency tracking for configuration macros

Petter Urkedal urkedal at nbi.dk
Sat May 23 04:36:15 PDT 2009


On 2009-05-23, Petter Urkedal wrote:
> On 2009-05-22, Boehm, Hans wrote:
> > How about the following:
> > 
> > - I've committed Ivan's diff61, minus the gc.h includes, so that it's off the table. 
> > 
> > - I'm not enthusiastic about the complicated include chain through gc.h.  Could we include private/config.h from only private/gcconfig.h, and then include that, or gc_priv.h, in the places in which gc.h is being newly included, and possibly in any others it might be needed?  That way this stays out of client visible headers, which I think is the right thing?
> 
> I've arranged so that including "gcconfig.h" is sufficient.  It must
> still be included before public headers because of the version check.
> 
> I had to include "gc_config_macros.h" directly from "gcconfig.h".  As I
> interpreted your other comment about the GC_*_THREADS macros,
> "gc_config_macros.h" is a mandatory supplement to the configured
> macros, so I think this makes sense anyway.

Please hold this.  I seem to have broken a few things in the last
version of the patch.  The original patch is the only version which I
properly tested.  I'll have a better look at it.

Petter


More information about the Gc mailing list