[Gc] gctest: use of AO_fetch_and_add1

Boehm, Hans hans.boehm at hp.com
Sun May 24 16:15:22 PDT 2009


Thanks.  Tested on an armv5b machine (where the fetch_and_add version by itself failed) and committed.

Hans

> -----Original Message-----
> From: gc-bounces at napali.hpl.hp.com 
> [mailto:gc-bounces at napali.hpl.hp.com] On Behalf Of Ivan Maidanski
> Sent: Saturday, May 23, 2009 2:26 PM
> To: gc at napali.hpl.hp.com
> Subject: [Gc] gctest: use of AO_fetch_and_add1
> 
> Hi!
> 
> AO_fetch_and_add1_full() has been replaced back with 
> LOCK/UNLOCK recently.
> But using LOCK/UNLOCK requires GC_allocate_ml to be exported 
> from DLL/DSO (which isn't (in my tree) since diff33 (Nov 
> 01)). I think it's not worth exporting privates just for 
> gctest (and whose use could be somehow avoided).
> 
> In the attached patch for test.c, I suggest checking for 
> AO_HAVE_fetch_and_add1_full and falling back to LOCK/UNLOCK 
> if missing.
> 
> Other solutions possible like having own GC_allocate_ml var in test.c.
> 
> Bye.
> 


More information about the Gc mailing list