Re[6]: [Gc] Small patch to allow initial and maximum heapsizesto be>2GB.

Ivan Maidanski ivmai at mail.ru
Thu May 28 13:57:54 PDT 2009


Hi!

"Talbot, George" <Gtalbot at locuspharma.com> wrote:
> Here's the patch again with strtoull() and _strtoui64()
> 
> --
> George T. Talbot
> <gtalbot at locuspharma.com>
> ...

My considerations:
1. strtoul() should be used instead of strtoull() unless _LLP64;
2. there (in gconfig.h) exists STRTOULL but it used incorrectly misc.c;
3. we should replace 1 atoi(), 1 atol() and 2->1 strtoul[l]() in misc.c with STRTOULL(str, NULL, 10/16) (16 for the latter case only) (0 is returned if error but no special error checking needed).
4. for MSWIN32, we should define STRTOULL (as _strtoui64) only if _WIN64 (gcconfig.h).
5. we should define STRTOULL at the end of gcconfig.h (if undef'ed before) as strtoull if _LLP64 or __LLP64__ are defined otherwise as strtoul.

Some tips for a patch submitter:
- create patches with "diff -ruN";
- attach patches instead of pasting to a letter's body.

Bye.



More information about the Gc mailing list