Re [Gc]: two patches

Petter Urkedal urkedal at nbi.dk
Thu Nov 19 23:51:35 PST 2009


On 2009-11-19, Ivan Maidanski wrote:
> Hi!
> "Daniel R. Grayson" <dan at math.uiuc.edu> wrote:
> > Here are some patches I needed to make.  The first allows  
> > substitutions such as CC="gcc -m64".
> 
> I'm not a guru in the compilation scripts but typically this is done thru CFLAGS, e.g. CFLAGS=-m64.

Yes, or looking at configure.ac it seems that the intension is that the
end-user sets GC_CFLAGS, since in CFLAGS some cases is overridden by
configure?

> >  The second gets around a  
> > deprecated include file in mac os x 10.6, but there might be a better  
> > way to do it.
> 
> The better way is to upgrade GC to the latest CVS version (I think the problem is already solved - at least, I don't see any compiler complain about deprecated headers - see http://ecls.sourceforge.net/logs_gc/osx).
> 
> > 
> > 
> > diff -ur --exclude=configure /Users/dan/src/M2/trunk/BUILD/dan/ 
> > builds.tmp/mac64.production/libraries/gc/tmp/gc-7.2alpha2/ 
> > libatomic_ops-1.2/configure.ac gc-7.2alpha2/libatomic_ops-1.2/ 
> > configure.ac
> > ...
> >   AC_CONFIG_FILES([Makefile src/Makefile src/atomic_ops/Makefile src/ 
> > atomic_ops/sysdeps/Makefile doc/Makefile tests/Makefile])
> > -AC_CONFIG_COMMANDS([default],[[]],[[PICFLAG=${PICFLAG}
> > -CC=${CC}
> > -DEFS=${DEFS}]])
> > +AC_CONFIG_COMMANDS([default],[[]],[[
> > +PICFLAG="${PICFLAG}"
> > +CC="${CC}"
> > +DEFS="${DEFS}"
> > +]])
> >   AC_OUTPUT
> > ...
> 
> Petter -
> Do you think it's worth applying?

The problem is solved in CVS head:

AC_CONFIG_COMMANDS([default],,
  [ srcdir=${srcdir}
    host=${host}
    CONFIG_SHELL=${CONFIG_SHELL-/bin/sh}
    CC="${CC}"
    DEFS="$DEFS" ])

On the other hand, I'm not sure why we substitute CC and DEFS like this, maybe
it's not needed anymore.  (The fragment is from 2005-10-10.)


More information about the Gc mailing list