Re[2]: [Gc] Patch for atomic_ops GCC sparc support

Ivan Maidanski ivmai at mail.ru
Tue Sep 1 23:43:01 PDT 2009


Hi!

"Boehm, Hans" <hans.boehm at hp.com> wrote:
> I believe the code came from Patrick Marlier.  I checked it in after wrapping most of it in a #ifndef NO_SPARC_V9, to allow an easier override if someone has really old hardware.  (I have a machine that may need it :-( )

It's better to have NO_SPARC_V9 prefixed with AO_ (since the header is included from a custom application).

> 
> Sorry about the long delay on this, and belated thanks.
> 
> I did not test.  Someone with a modern SPARC probably should.
> 
> I suspect this could use further improvement:
> 
> - Some of the comments now look obsolete.
> 
> - The old file assumed TSO.  I suspect that's the right assumption.  Especially under TSO, I'm suspicious that the membar's aren't needed for compare_and_swap?  However, it would probably help a lot to define AO_nop_full() as membar #StoreLoad (or stronger, though I suspect that doesn't matter for TSO?).
> 
> Hans

Bye.


More information about the Gc mailing list