Re[2]: [Gc] Patch for handling zero mp passed to GC_init_gcj_malloc

Ivan Maidanski ivmai at mail.ru
Fri Sep 11 23:59:21 PDT 2009


Hi!

"Boehm, Hans" <hans.boehm at hp.com> wrote:
> This looks fine to me, though the corresponding  comment in gc_gcj.h also needs adjustment.

Please supply the patch for gc_gcj.h.

> I'm actually not sure that the default can really do more than that, other than by conservatively scanning the object using GC_size() or equivalent.  If it's invoked, there is no available bitmap.  The conservative scanning code would be an improvement over aborting.

May be. The patch for it is on You (or delay this code changes until some gc73a+).

>
> Hans
>
> > Hi!
> >
> > This small patch (ivmai126.diff) simply substitutes a fake
> > mark proc (aborting with a message if GC_debug_gcj_malloc()
> > is called) if mp==0 passed to GC_init_gcj_malloc() (ideally
> > such mark proc should handle GC_DS_LEN and GC_DS_BITMAP, and
> > should abort only in case of GC_DS_PROC, but this requires
> > more efforts and code changes).

Bye.


More information about the Gc mailing list