Re[8]: [Gc] Dependency tracking for configuration macros

Ivan Maidanski ivmai at mail.ru
Sat Sep 12 06:51:34 PDT 2009


Hi!

Petter Urkedal <urkedal at nbi.dk> wrote:
> > > Patch 1
> > > 
> > > Fix/add inclusion of private/config.h.
> > >     * include/private/gc_priv.h, include/private/gc_pmark.h, gc_cpp.cc,
> > >     tests/test.c: Change include of config.h to private/config.h.
> > >     * tests/test_cpp.cc: Include private/config.h.
> > > ...
> > 
> > Ok (but I think "#undef GC_BUILD" should be added after including
> > config.h in test_cpp.cc (as  in test.c)). I'll commit patch 1 in
> > several days if Hans don't mind.
> 
> Thanks.  I don't think #undef GC_BUILD is necessary on behalf of
> config.h, since GC_BUILD is not a configuration macro.  As far as I
> understand the use of GC_BUILD, it indicates that the libgc library is
> being built, and this is only known by the build system, not by
> configure.

Yes GC_BUILD is not a configuration macro but: just to look/behave the same as test.c (GC_BUILD could be specified in the cmd-line or GC makefile (for backward compatibility) so it should be undefined in the test modules otherwise GC_API wouldn't turn into __dllimport for GC_DLL case).

Bye.


More information about the Gc mailing list