[Gc] Latest cvs commits

Petter Urkedal urkedal at nbi.dk
Wed Sep 16 11:19:52 PDT 2009


On 2009-09-16, Ivan Maidanski wrote:
> If no objections, I've checked in the following: ivmai131.diff, ivmai132.diff, ivmai125.diff, ivmai126.diff, ivmai134.diff, ivmai127.diff, ivmai138.diff, ivmai124.diff, ivmai128.diff.

I discovered that the patch ivmai132.diff, in particular

  * Makefile.am: Prefix PTHREADS, DARWIN_THREADS, WIN32_THREADS with
    "GC_".

breaks the Automake based build since it lacks the corresponding updates
of AM_CONDITIONAL definitions in configure.ac.  However, I don't see any
reason to add the GC_ prefix here, since this is strictly local to the
project.  I would therefore suggest to just revert that part of the
patch.
-------------- next part --------------
diff --git a/Makefile.am b/Makefile.am
index 64048c3..fb658e2 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -59,15 +59,15 @@ libgc_la_SOURCES = \
 # C Library: Architecture Dependent
 # ---------------------------------
 
-if GC_PTHREADS
+if PTHREADS
 libgc_la_SOURCES += pthread_support.c pthread_stop_world.c
 endif
 
-if GC_DARWIN_THREADS
+if DARWIN_THREADS
 libgc_la_SOURCES += darwin_stop_world.c
 endif
 
-if GC_WIN32_THREADS
+if WIN32_THREADS
 libgc_la_SOURCES += win32_threads.c
 endif
 


More information about the Gc mailing list