[Gc] Patch for warnings suppression in test_cpp

Boehm, Hans hans.boehm at hp.com
Wed Sep 16 11:26:56 PDT 2009


Ivan -

What are the warnings?

Replacing

T *p = X;

with

T *p;
p = X;

seems to be an uglification.

Does it really want

T *p(X);

?

In general, my attitude has been that we don't want to mess up the code very much or slow it down in critical places in order to avoid compiler warnings.  Things have gotten better recently, but historically a goal of zero compiler warnings across all possible compilers didn't seem practical. 

Hans

> -----Original Message-----
> From: gc-bounces at napali.hpl.hp.com 
> [mailto:gc-bounces at napali.hpl.hp.com] On Behalf Of Ivan Maidanski
> Sent: Wednesday, September 16, 2009 9:13 AM
> To: gc at napali.hpl.hp.com
> Subject: [Gc] Patch for warnings suppression in test_cpp
> 
> Hi!
> 
> The patch (ivmai141.diff) is for suppression of several 
> compiler warnings.
> I'll commit it in several days.
> 
> ChangeLog entries:
> 
> 	* tests/test_cpp.cc (WinMain, main): Suppress several compiler
> 	warnings.
> 
> Bye.
> 


More information about the Gc mailing list