Re[2]: [Gc] Dependency tracking for configuration macros

Ivan Maidanski ivmai at mail.ru
Thu Sep 24 12:29:38 PDT 2009


Hi!

Hans -

What do you think of this patch for Makefile.am by Petter Urkedal?

The description: http://permalink.gmane.org/gmane.comp.programming.garbage-collection.boehmgc/2662

The patch (only N2): http://permalink.gmane.org/gmane.comp.programming.garbage-collection.boehmgc/3147

> > Petter Urkedal <urkedal at nbi.dk> wrote:
> > > On 2009-09-11, Ivan Maidanski wrote:
> > > > Petter, could you repost all your ideas and pending suggested patches regarding build scripts (including for acinclude.m4) having today's CVS snapshot? (It's now possible to have config.h at GC build.) It might be good to freshen some scripts now.
> ...
> Patch 2
> 
> Generate and use config.h instead of -D options.
>     * configure.ac: Move include flag from ${INCLUDE} ...
>     * Makefile.am: ... to AM_CPPFLAGS and also add the build directory.
> 
>     * configure.ac: Call AM_CONFIG_HEADER([include/private/config.h]).
>     * configure.ac: Add documentation to all AC_DEFINE either directly
>     or using AH_TEMPLATE.
> ...
> diff --git a/Makefile.am b/Makefile.am
> index fb658e2..6fb4a47 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -32,6 +32,8 @@
>  # endif
>  SUBDIRS =
>  
> +AM_CPPFLAGS = -I$(top_builddir)/include -I$(top_srcdir)/include
> +
>  # Initialize variables so that we can declare files locally.
>  EXTRA_DIST = 
>  lib_LTLIBRARIES =
> diff --git a/acinclude.m4 b/acinclude.m4
> index 72602a0..070f85d 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -37,10 +37,13 @@ AC_DEFUN(GC_SET_VERSION, [
>      AC_MSG_ERROR([nonconforming PACKAGE_VERSION='$PACKAGE_VERSION'])
>    fi
>    
> -  AC_DEFINE_UNQUOTED(GC_VERSION_MAJOR, $GC_VERSION_MAJOR)
> -  AC_DEFINE_UNQUOTED(GC_VERSION_MINOR, $GC_VERSION_MINOR)
> +  AC_DEFINE_UNQUOTED([GC_VERSION_MAJOR], $GC_VERSION_MAJOR,
> +		     [The major version number of this GC release.])
> +  AC_DEFINE_UNQUOTED([GC_VERSION_MINOR], $GC_VERSION_MINOR,
> +		     [The minor version number of this GC release.])
>    if test :$GC_ALPHA_VERSION: != :: ; then
> -    AC_DEFINE_UNQUOTED(GC_ALPHA_VERSION, $GC_ALPHA_VERSION)
> +    AC_DEFINE_UNQUOTED([GC_ALPHA_VERSION], $GC_ALPHA_VERSION,
> +		       [The alpha version number, if applicable.])
>    fi
> ...

Bye.


More information about the Gc mailing list