[Gc] RE: Unreviewed^3 patches (Solaris libraries)

Boehm, Hans hans.boehm at hp.com
Mon Mar 22 13:11:13 PST 2010


[Added gc list, in case someone else there has more insight on the last patch.]

For what it's worth, it looks to me like the closest equivalent to this in the current gc tree is

      *-*-solaris*)
        AC_DEFINE(GC_SOLARIS_THREADS)
        AC_DEFINE(THREAD_LOCAL_ALLOC)
        THREADDLLIBS="-lpthread -lrt"
        if test "$GCC" != yes; then
          CFLAGS="$CFLAGS -O"
          need_atomic_ops_asm=true
        fi
        ;;

Thus it looks like:

a) We never got the 2.8 patch that created the issue.  I'm not sure it matters now.

b) We consistently use -lrt.  I remember that was necessary sometime in prehistory, but I have no idea about recent Solaris releases.

I'm sure I'm in a much worse position than Rainer to test any of this.  Assuming -lrt is really no longer needed, the patch looks fine to me for the gcc tree, but I'm not sure who should really be approving the change.

Hans

> -----Original Message-----
> From: Rainer Orth [mailto:ro at CeBiTec.Uni-Bielefeld.DE] 
> Sent: Monday, March 22, 2010 3:12 AM
> To: gcc-patches at gcc.gnu.org
> Cc: Jan Hubicka; Uros Bizjak; Boehm, Hans
> Subject: Unreviewed^3 patches
> 
> The following patches have remained unreviewed for some time. 
>  I've Cc'ed the respective maintainers.
> 
> 	PATCH: Fix 64-bit profiling on Solaris 10+/x86 (PR target/38085)
> 	http://gcc.gnu.org/ml/gcc-patches/2010-03/msg00609.html
> 
> Needs an i386 maintainer.  I'd like to backport this to the 
> 4.4 branch, too.
> 
> 	PATCH: Support TLS with Sun as on Solaris 2/x86
>         http://gcc.gnu.org/ml/gcc-patches/2010-03/msg00620.html
> 
> Needs an i386 maintainer.
> 
> 	PATCH: Support Sun symbol versioning in libssp
>         http://gcc.gnu.org/ml/gcc-patches/2010-02/msg01005.html
> 
> No libssp maintainer is listed, so probably needs a global reviewer.
> 
> 	PATCH: Only use /usr/lib/lwp in boehm-gc on Solaris 8
>         http://gcc.gnu.org/ml/gcc-patches/2010-03/msg00128.html
> 
> No boehm-gc maintainer is listed either, so I've Cc'ed Hans Boehm.
> 
> 	Rainer
> 
> --
> --------------------------------------------------------------
> ---------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
> 


More information about the Gc mailing list