Re[2]: [Gc] [PATCH] fixing couple of typos in cord.h

Ivan Maidanski ivmai at mail.ru
Mon May 31 09:50:26 PDT 2010


Mon, 31 May 2010 16:11:08 +0000 "Boehm, Hans" <hans.boehm at hp.com>:

> If you like, I can put it in my tree, and check it in at the next opportunity.

No matter for me... I checked it in (better early than postpone).

>  I agree that we shouldn't go out of our way to fix such stuff.  But I think some people do use this code.  And I don't know of any fundamental problems with it, aside from the fact that some of the varargs handling for IO is not 100% portable.  But that's a relatively minor part of the package.  My impression is that it has been much less actively maintained than the rest of the collector in part because it has a lot less platform dependencies, and thus needs a lot less work.
> 
> The gcc ropes package is similar, and probably somewhat more actively maintained.  But it's a (usually) reference-counted C++ package, so it's not quite the same thing.
> 
> Hans
> 
> > -----Original Message-----
> > From: gc-bounces at linux.hpl.hp.com 
> > [mailto:gc-bounces at linux.hpl.hp.com] On Behalf Of Ivan Maidanski
> > Sent: Monday, May 31, 2010 12:26 AM
> > To: Alexander Belchenko
> > Cc: gc at linux.hpl.hp.com
> > Subject: Re: [Gc] [PATCH] fixing couple of typos in cord.h
> > 
> > 
> > Mon, 31 May 2010 08:08:30 +0300 Alexander Belchenko <bialix at ukr.net>:
> > 
> > > Hi,
> > > 
> > > I've encountered couple of typos in cord.h while reading it. I've 
> > > decided to fix them because it took me some time to understand the 
> > > text, because I'm not native English speaker.
> > 
> > cord is an outdated stuff (and not maintained/updated for a 
> > long time), IMHO. Should we really care of something (typos, 
> > warnings, K&R style, etc.) except for serious bugs in it?
> > 
> > > 
> > > Alexander
> > > 
> > > === modified file 'include/cord.h'
> > > --- include/cord.h	2010-05-30 13:59:56 +0000
> > > +++ include/cord.h	2010-05-30 14:40:12 +0000
> > > @@ -28,7 +28,7 @@
> > >   *   concatenating instructions onto a cord representing 
> > the output file.
> > >   * - A text editor that converts the input file to a cord, and then
> > >   *   performs editing operations by producing a new cord 
> > representing
> > > - *   the file after echa character change (and keeping the 
> > old ones in an
> > > + *   the file after each character change (and keeping the 
> > old ones in an
> > >   *   edit history)
> > >   *
> > >   * For optimal performance, cords should be built by @@ 
> > -147,7 +147,7 
> > > @@
> > >  /* Functions that operate on cord positions.  The easy way 
> > to traverse	*/
> > >  /* cords.  A cord position is logically a pair consisting 
> > of a cord	*/
> > >  /* and an index into that cord.  But it is much faster to 
> > retrieve a	*/
> > > -/* charcter based on a position than on an index.  
> > Unfortunately,	*/
> > > +/* character based on a position than on an index.  
> > Unfortunately,	*/
> > >  /* positions are big (order of a few 100 bytes), so 
> > allocate them with	*/
> > >  /* caution.						
> > 		*/
> > >  /* Things in cord_pos.h should be treated as opaque, 
> > except as		*/



More information about the Gc mailing list