[Gc] unportable test(1) construct in configure script

Thomas Klausner tk at giga.or.at
Sun Aug 26 10:03:29 PDT 2012


Hi!

configure{,.ac} is using a bash extension to test(1), the "=="
operator, which is not supported by most other shells or even test(1)
in GNU coreutils. Please use "=" instead. I'll attach a patch (against
7.2d).
 Thomas
-------------- next part --------------
$NetBSD$

--- configure.ac.orig	2012-08-09 20:25:13.000000000 +0000
+++ configure.ac
@@ -337,7 +337,7 @@ if test $compiler_xlc = yes -a "$powerpc
   AC_DEFINE([DARWIN_DONT_PARSE_STACK], 1, [See doc/README.macros.])
 fi
 
-if test "$GCC" == yes; then
+if test "$GCC" = yes; then
   # Disable aliasing optimization unless forced to.
   AC_MSG_CHECKING([whether gcc supports -fno-strict-aliasing])
   ac_cv_fno_strict_aliasing=no
@@ -442,8 +442,8 @@ esac
 AC_MSG_RESULT($enable_shared)
 
 # Compile with GC_DLL defined unless building static libraries.
-if test "${enable_shared}" == yes; then
-  if test "${enable_static}" == no; then
+if test "${enable_shared}" = yes; then
+  if test "${enable_static}" = no; then
     AC_DEFINE(GC_DLL)
     # FIXME: Also pass -fvisibility=hidden option if GCC v4+ and not Win32.
   fi
@@ -707,7 +707,7 @@ if test -n "${with_cross_host}"; then
              [Define to tune the collector for small heap sizes.])
 fi
 
-if test "$enable_gc_debug" == "no"; then
+if test "$enable_gc_debug" = "no"; then
    AC_DEFINE([NO_DEBUGGING], 1,
              [Disable debugging, like GC_dump and its callees.])
 fi


More information about the Gc mailing list