Re: [Gc] Bug in GC_malloc_explicitly_typed_ignore_off_page()

Ivan Maidanski ivmai at mail.ru
Sat Dec 8 00:55:11 PST 2012


Hi Reimer,

Thanks for reporting & fixing the bug.
I've applied your patch (https://github.com/ivmai/bdwgc/commit/13a88c0704d6f83ff97be0a246692e0e2da292f5) both to master and release-7_2 branches (https://github.com/ivmai/bdwgc).

Regarding GC_generic_malloc_ignore_off_page, again you are right - it is a companion for GC_generic_malloc and, thus, it is reasonable that it should have similar visibility. I've made it public today (only master branch) - https://github.com/ivmai/bdwgc/commit/7bd92c91f5712ff6723eb2479d0442cd6154a10e

Regards,
Ivan

3 Dec 2012, 18:26 Reimer Behrends <behrends at gmail.com>:
>	
>
>
	
	
>
		
		
			
>Hi folks,
>

>
it appears as though GC_malloc_explicitly_typed_ignore_off_page() has a 
>
typo. Namely, it uses BYTES_TO_WORDS() instead of BYTES_TO_GRANULES() in 
>
the else branch. When the result is then used with GRANULES_TO_WORDS() 
>
to calculate an offset, that offset is incorrect.
>

>
I've attached a patch against 7.2d.
>

>
On a related note, is it intended that 
>
GC_generic_malloc_ignore_off_page() is marked as GC_INNER instead of 
>
GC_API and does not have a prototype in gc_mark.h?
>

>
			Reimer Behrends
>

>
>			
>_______________________________________________
>
Gc mailing list
>
>Gc at linux.hpl.hp.com
>
>http://www.hpl.hp.com/hosted/linux/mail-archives/gc/
>
>		
		
	

	
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://napali.hpl.hp.com/pipermail/gc/attachments/20121208/1f610c97/attachment.htm


More information about the Gc mailing list