Re: [Gc] [PATCH] define HANDLE_FORK on unix platforms with pthreads
ivmai at mail.ru
Mon Feb 20 10:21:31 PST 2012
1. I've committed your patch to master with some modifications. I suppose this patch should be committed to "release" branch.
2. Also, I've added a check for pthread_atfork returned value.
3. I think fork-related code should be added to Cygwin (I've not tested it yet).
4. And, slightly related to the topic, I've discovered GC_unregister_my_thread and GC_thread_exit_proc for Win32 lack GC_wait_for_gc_completion call - seems to me it is not correct.
20 02 2012, 10:15 Ivan Maidanski <ivmai at mail.ru>:
> Hi Richard,
> Thank you for the information.
> 20 02 2012, 03:38 "Richard O'Keefe" <ok at cs.otago.ac.nz>:
> > On 19/02/2012, at 9:56 AM, Andy Wingo wrote:
> > > On Fri 17 Feb 2012 21:45, Ivan Maidanski <ivmai at mail.ru> writes:
> > >
> > >> It seems you're proposing the right thing but I guess your patch could
> > >> break build for some targets (there are some many Unix targets supported
> > >> like xBSD, RTEMS, NaCl, Android, Darwin, DG/UX, HP/UX, Aix, Irix,
> > >> Solaris... - does at least pthread_atfork exist everywhere?
> > pthread_atfork was in Solaris 2.10 (which I'm still using) and of course
> > remains in OpenSolaris (and its forks) and Solaris 2.11. It's also in
> > Mac OS X 10.6. According to a compatibility list I've been building,
> > it's in Linux 2.6 and OpenBSD 4.7, and HP-UX 11i. I have some AIX manuals
> > but haven't integrated those yet, sorry.
More information about the Gc