[Gc] Re: Patch for native support of long weakrefs
ivmai at mail.ru
Sat Nov 17 07:36:03 PST 2012
I've reviewed your latest commit and adjusted some code (https://github.com/ivmai/bdwgc/compare/7730d81...df392f3).
In the my recent commit, I've nonetheless decided to move locking out of GC_unregister_disappearing_link_inner (minor code duplication should be ok, GC_unregister_disappearing_link is then, anyway, quite small and straightforward).
Please merge https://github.com/ivmai/bdwgc/tree/add-long-weakref to your add-long-weakref branch and go on.
About naming: I think GC_[un]register/move_disappearing_link_long name is long (and major part of it is common with GC_X_disappearing_link). I suggest GC_..._long_link instead. Any objections or other candidates?
16 11 2012 22:03:50 Zach Saw <zach.saw at gmail.com>:
>>It seems we both start working on the same changes - I do it in my way (but haven't yet pushed to github). I'll merge your changes today to push.
>>Shouldn't you wait for me to finish adding long-weakref first?
>Otherwise it would be double work for you.
>Or would you want me to wait until you are done merging, and then I update my branch from master before continuing to work on adding long-weakref?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Gc