[Gc] Re[4]: [Patch 2/2] Aarch64 libatomic_ops and Gc basic port

Ivan Maidanski ivmai at mail.ru
Fri Jan 25 12:10:40 PST 2013


 Hi Yvan,

gcc-boehmgc at bdwgc git repository is a "read-only" branch I used to identify code that worth merging to master.

I've committed your libatomic code to  https://github.com/ivmai/libatomic_ops/tree/add-aarch64-support - it still need to be improved. I've already performed some changes to it:
*  https://github.com/ivmai/libatomic_ops/commit/da37b2c2e56291d54ff16fa24df1498783ed881a
*  https://github.com/ivmai/libatomic_ops/commit/fbfc0a4f5b2cfccb7f9a51a46cae7ce621ced4e7

To be fixed:
* AO_load_acquire - it is defined twice (in aarch64.h and in ordered_load.h) - are they the same at asm level?

Also, it would be good if you provide us with the assembly output for each primitive in aarch64.h - just to check verify gcc output.

The TODO items I've placed to aarch64.h are not strictly necessary to be done to have the file merged to master.

Regards,
Ivan

24 01 2013, 12:55 +01:00 Yvan Roux <yvan.roux at linaro.org>:
>Hi Ivan and Marcus,
>
>Thanks for the comments and committing.
>
>I've a question for you two, on the proper way to have this merged
>into GCC. Should it be first merged into Ivan's gcc-boehmgc github
>branch or directly into the FSF repo ? Regarding the FSF, Marcus this
>has to go into the AArch64 branch I guess ?
>
>Cheers,
>Yvan
>
>On 23 January 2013 20:51, Ivan Maidanski < ivmai at mail.ru > wrote:
>> Hi Marcus and Yvan,
>>
>> I've committed the proposed GC patch (with the 2 corrections mentioned
>> below) to master branch:
>>  https://github.com/ivmai/bdwgc/commit/7b5acfba9a1df00f0427d1d2e1a92570da3ab2d1
>>
>> Regards,
>> Ivan
>>
>> Wed, 23 Jan 2013, 18:15 UTC Marcus Shawcroft < marcus.shawcroft at arm.com >:
>>
>> On 23/01/13 17:53, Yvan Roux wrote:
>>
>>> @@ -557,6 +568,7 @@
>>> /* running Amdahl UTS4 */
>>> /* S390 ==> 390-like machine */
>>> /* running LINUX */
>>> + /* AARCH64 ==> ARM 64-bit */
>>
>> The define AARCH64 represents the ARM AArch64 execution state therefore
>> I think this comment should read:
>>
>> AARCH64 -> ARM AArch64
>>
>>
>>> +# define DATASTART ((ptr_t)__data_start)
>>> + /* __stack_base__ is set in newlib/libc/sys/arm/crt0.S */
>>
>> That comment doesn't make sense in this context.
>>
>> Cheers
>> /Marcus
>>
>>
>>
>> _______________________________________________
>> Gc mailing list
>>  Gc at linux.hpl.hp.com
>>  http://www.hpl.hp.com/hosted/linux/mail-archives/gc/
>>
>>
>_______________________________________________
>Gc mailing list
>Gc at linux.hpl.hp.com
>http://www.hpl.hp.com/hosted/linux/mail-archives/gc/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://napali.hpl.hp.com/pipermail/gc/attachments/20130126/01bcd04e/attachment.htm


More information about the Gc mailing list