[Gc] [PATCH 1/3] Fix trailing spaces.

Ondřej Bílka neleai at seznam.cz
Mon Jul 8 09:11:37 PDT 2013


Hi,

I am writing tool to help with various style issues. This will
simplify code review as these issues will be solved automatically.

As gcc includes boehms-gc I decided to make changes upstream.

These patches are requisite for others as I need handle these cases
first. It does not matter what leading space policy is as long as it can
be enforced by script.

We could maintain all those properties for all. It just suffices to add
hook that does formatting or/and I could periodically send patch to clean
errors. What do you prefer more?

My formatter is here,
https://github.com/neleai/stylepp
and these patches were generated by script/stylepp_space command.

We could also issue warning about various style issues, what do you want
most?

Please use flags to ignore whitespaces like

hg annotate -w
git blame -w
patch -l
git apply --ignore-space

Could you also verify each patch by git diff -w that it indeed touches
only whitespaces?


---
 extra/symbian.cpp |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/extra/symbian.cpp b/extra/symbian.cpp
index 29a960d..11bf600 100644
--- a/extra/symbian.cpp
+++ b/extra/symbian.cpp
@@ -14,11 +14,11 @@ int GC_get_main_symbian_stack_base()
 	{
 	TThreadStackInfo aInfo;
 	TInt err = RThread().StackInfo(aInfo);
-	if ( !err ) 
+	if ( !err )
 		{
 		return aInfo.iBase;
 		}
-	else 
+	else
 		{
 		return 0;
 		}
@@ -34,19 +34,19 @@ char* GC_get_private_path_and_zero_file()
 	fs.PrivatePath( path );
 	fs.Close();
 	_LIT( KCDrive, "c:" );
-	path.Insert( 0, KCDrive );	
+	path.Insert( 0, KCDrive );
+
 
-	
 	//convert to char*, assume ascii
 	TBuf8<KMaxFileName> path8;
 	path8.Copy( path );
 	_LIT8( KZero8, "zero" );
 	path8.Append( KZero8 );
-	
+
 	size_t size = path8.Length() + 1;
 	char* copyChar = (char*) malloc( size );
 	memcpy( copyChar, path8.PtrZ(), size );
-	
+
 	return copyChar; // ownership passed
 	}
 
-- 
1.7.10.4




More information about the Gc mailing list