[httperf] patch to add bind address support to httperf/idleconn

Ted Bullock tbullock at canada.com
Tue Jul 10 20:45:05 PDT 2007


Balazs,

Thanks for the patch.

Since I don't have a publicly available CVS repository, it is currently
difficult for people other than myself to create patches against the
current development version of httperf.  Sorry, I'll try to find an
appropriate solution to this in the future.  Maybe sourceforge if Martin
 and his associates are agreeable.

Anyways,

Before I will apply the patch please talk with Martin Arlitt and
myselfabout licensing (httperf is distributed under GPL 2 with an
OpenSSL exception) and whether you agree to distribute your
modifications under those conditions.

Additionally, please avoid introducing extraneous white space along with
your patch

e.g.

@@ -847,6 +847,7 @@
       goto failure;
     }

+
   if (fcntl (sd, F_SETFL, O_NONBLOCK) < 0)
     {
       fprintf (stderr, "%s.core_connect.fcntl: %s\n",

Also, since you are adding a new argument to httperf, you should also
update the httperf manpage, changelog and with the appropriate
documentation, and include that along with the patch.  Unfortunately,
the work is not complete until the documentation is updated.

Lastly, I noticed that you fixed the compiler warning in idleconn.c
regarding the *incompatible pointer type*.  Thanks.  However, please try
 to avoid making more than one type of change per patch.  Fixes and
enhancements should be split from each other, and should be submitted
via independent patches with one complete fix or enhancement per patch

Thanks for the effort, I hope to hear back from you soon.

-Ted

Balazs Scheidler wrote:
> ops, forgot the patch :)
> 
> On Fri, 2007-07-06 at 08:58 +0200, Balazs Scheidler wrote:
>> hi,
>>
>> We needed to tell httperf/idleconn the IP address to use for outgoing
>> connections, and therefore implemented the attached patch.
>>
>> It adds new arguments to httperf (--bind) and an optional fourth
>> argument to idleconn that specifies the IP address to bind to.
>>
>> Please apply. Thanks.
>>


-- 
Theodore Bullock, <tbullock at canada.com, tedbullock at gmail.com>
B.Sc Software Engineering
Bike Across Canada Adventure http://www.comlore.com/bike


More information about the httperf mailing list