Dired 7.4 bug: Bug on Mule

Ishikawa Ichiro (ichiro@ccsr.u-tokyo.ac.jp)
Thu, 1 Sep 94 10:06:55 +0900


Emacs  : GNU Emacs 19.25.4 of Mon Aug 22 1994 on acc1 (sparc-sun-sunos4.1)
Package: Dired

dired-view-file and dired-find-file-other-frame need not be overloaded
on the current version of Mule. Please apply the following patch.

diff -aruN /home/acc1/ichiro/tmp/efs-1.11/dired.el /home/acc1/ichiro/lib/mule2/lisp/dired.el
--- /home/acc1/ichiro/tmp/efs-1.11/dired.el	Thu Sep  1 10:01:34 1994
+++ /home/acc1/ichiro/lib/mule2/lisp/dired.el	Thu Sep  1 10:01:35 1994
@@ -2720,17 +2720,6 @@
     (interactive)
     (find-file (dired-get-filename)))
   
-  (defun dired-view-file ()
-    "In dired, examine a file in view mode, returning to dired when done.
-When file is a directory, show it in this buffer if it is inserted;
-otherwise, display it in another buffer."
-    (interactive)
-    (let ((file (dired-get-filename)))
-      (if (file-directory-p file)
-	  (or (dired-goto-subdir file)
-	      (dired file))
-	(view-file file))))
-  
   (defun dired-find-file-other-window (&optional display)
     "In dired, visit this file or directory in another window.
 With a prefix, the file is displayed, but the window is not selected."
@@ -2738,14 +2727,24 @@
     (let ((file (dired-get-filename)))
       (if display
 	  (dired-display-file file)
-	(find-file-other-window file))))
+	(find-file-other-window file)))))
   
   ;; Only for Emacs 19
-  (defun dired-find-file-other-frame ()
-    "In dired, visit this file or directory in another frame."
-    (interactive)
-    (find-file-other-frame (dired-get-filename))))
+(defun dired-find-file-other-frame ()
+  "In dired, visit this file or directory in another frame."
+  (interactive)
+  (find-file-other-frame (dired-get-filename)))
 
+(defun dired-view-file ()
+  "In dired, examine a file in view mode, returning to dired when done.
+When file is a directory, show it in this buffer if it is inserted;
+otherwise, display it in another buffer."
+  (interactive)
+  (let ((file (dired-get-filename)))
+    (if (file-directory-p file)
+	(or (dired-goto-subdir file)
+	    (dired file))
+      (view-file file))))
 
 (defun dired-display-file (file)
   "In dired, displays this file or directory in the other window."