Re: Dired 7.5 bug: it core-dumps when dired-apropos is run
Michael Sperber [Mr. Preprocessor] (sperber@informatik.uni-tuebingen.de)
Sat, 01 Oct 94 11:17:13 +0100
>>>>> "sandy" == sandy <sandy@ibm550.sissa.it> writes:
>>>>> On Tue, 27 Sep 94 15:24:03 +0100,
sandy> sboff@hp735.stru.polimi.it (Giacomo Boffi) said:
>> i hit the 'a' key in dired, the minibuffer prompts for a regexp, i enter something,
>> press RET, ciao... (i.e., xemacs dumps core).
sandy> This is an XEmacs bug. I'm not sure what bug, but the problem isn't
sandy> with dired. A core dump is always a bug in Emacs. No lisp code
sandy> should ever cause Emacs to dump core.
sandy> Michael or Andy, do you get this?
Well, the bug is pretty obvious once you look at it, and it's not in
XEmacs. dired-apropos feeds something pretty bizarre into
with-output-to-temp-buffer as the name of the temporary buffer.
As I said, out here, the name shows up on the modeline, XEmacs doesn't
crash. So I can't say if XEmacs should be made safer somewhere.
Off-hand, I can't say, especially since the C code of
with-output-to-temp-buffer is identical to that of FSFmacs 19.25.
Cheers =8-} Chipsy
*** dired-help.el~ Mon Sep 5 01:19:03 1994
--- dired-help.el Sat Oct 1 11:12:12 1994
***************
*** 238,246 ****
(lambda ()
(dired-apropos-internal string var-p)
nil)))
! (with-output-to-temp-buffer
! (dired-apropos-internal string var-p))
! (print-help-return-message)))
(defun dired-apropos-internal (string &optional var-p)
(let ((case-fold-search t)
--- 238,246 ----
(lambda ()
(dired-apropos-internal string var-p)
nil)))
! (with-output-to-temp-buffer "*Help*"
! (dired-apropos-internal string var-p)
! (print-help-return-message))))
(defun dired-apropos-internal (string &optional var-p)
(let ((case-fold-search t)