Dired 7.9 bug: dired should use easymenu

SL Baur (steve@altair.xemacs.org)
Tue, 5 May 1998 15:45:33 -0700


Michael, would you please apply this patch to dired?  Thanks.

1998-05-05  SL Baur  <steve@altair.xemacs.org>

	* dired-xemacs.el (dired-install-menubar): Use easy-menu for
	adding menus to menubar.

--- dired-xemacs.el~	Thu Feb 26 14:33:36 1998
+++ dired-xemacs.el	Tue May  5 15:37:52 1998
@@ -275,19 +275,17 @@
   "Installs the Dired menu at the menubar."
   (if (null dired-help-menu)
       (dired-setup-menus))
-  (if (and (featurep 'menubar) current-menubar)
-      (progn
-	(let ((buffer-menubar (copy-sequence current-menubar)))
-	  (set-buffer-menubar buffer-menubar)
-	  (mapcar
-	   (function
-	    (lambda (pair)
-	      (let ((name (car pair))
-		    (menu (symbol-value (cdr pair))))
-		(add-submenu nil (cons name menu)))))
-	   dired-menubar-menus))
-	(add-menu-button '("Help") (list "---"))
-	(add-submenu '("Help") (cons "Dired" dired-help-menu)))))
+  (when (and (featurep 'menubar) current-menubar)
+    (mapcar
+     (function
+      (lambda (pair)
+	(let ((name (car pair))
+	      (menu (symbol-value (cdr pair))))
+	  (easy-menu-add (cons name menu)))))
+     dired-menubar-menus)
+    (unless (featurep 'infodock)
+      (add-menu-button '("Help") (list "---"))
+      (add-submenu '("Help") (cons "Dired" dired-help-menu)))))
 
 (add-hook 'dired-mode-hook 'dired-install-menubar)
 


Emacs  : XEmacs 21.0  (i586-pc-linux, Mule) of Sun May  3 1998 on altair.xemacs.org
Package: Dired

current state:
==============
(setq
 dired-version "7.9"
 dired-backup-if-overwrite nil
 dired-chown-program "chown"
 dired-cleanup-alist '(("tex" ".toc" ".log" ".aux" ".dvi")
		       ("latex" ".toc" ".log" ".aux" ".idx" ".lof" ".lot"
			".glo" ".dvi")
		       ("bibtex" ".blg" ".bbl")
		       ("texinfo" ".cp" ".cps" ".fn" ".fns" ".ky" ".kys"
			".pg"
			".pgs" ".tp" ".tps" ".vr" ".vrs")
		       ("patch" ".rej" ".orig") ("backups" "~")
		       ("completion-ignored-extensions" "0" "1" "2" "3" "4"
			"5"
			"6" "7" "8" "9" ".log" "bin" ".tc" ".toc" "#" "-"
			".E"
			".class" ".o" ".elc" "~" ".bin" ".lbin" ".fasl"
			".dvi"
			".toc" ".log" ".aux" ".a" ".ln" ".lof" ".blg" ".bbl"
			".glo" ".idx" ".lot" ".fmt" ".diff" ".oi" ".class")
		       )
 dired-compression-method 'gzip
 dired-compression-method-alist '((gzip ".gz" ("gzip") ("gzip" "-d") "-f")
				  (compress ".Z" ("compress" "-f")
				   ("compress" "-d") "-f")
				  (pack ".z" ("pack" "-f") ("unpack"))
				  (compact ".C" ("compact") ("uncompact")))
 dired-copy-preserve-time t
 dired-dwim-target nil
 dired-failed-marker-shell ?\!
 dired-filename-re-ext "\\..+\\'"
 dired-find-subdir nil
 dired-gnutar-program nil
 dired-keep-marker-compress t
 dired-keep-marker-copy ?C
 dired-keep-marker-hardlink ?H
 dired-keep-marker-kill ?K
 dired-keep-marker-rename t
 dired-keep-marker-symlink ?S
 dired-keep-marker-uucode ?U
 dired-kept-versions 2
 dired-listing-switches "-al"
 dired-local-variables-file ".dired"
 dired-ls-F-marks-symlinks nil
 dired-ls-program "ls"
 dired-mail-reader 'vm
 dired-mode-line-modified "-%s%s%s-"
 dired-no-confirm nil
 dired-omit-extensions '(".oi" ".diff" ".fmt" ".ln" ".a" ".fasl" ".lbin"
			 ".bin"
			 ".elc" ".o" ".class" ".E" "-" "#" ".tc" "bin" "9"
			 "8"
			 "7" "6" "5" "4" "3" "2" "1" "0" "~" ".orig" ".rej"
			 ".vrs" ".vr" ".tps" ".tp" ".pgs" ".pg" ".kys" ".ky"
			 ".fns" ".fn" ".cps" ".cp" ".bbl" ".blg" ".glo"
			 ".lot"
			 ".lof" ".idx" ".dvi" ".aux" ".log" ".toc")
 dired-omit-files nil
 dired-omit-regexps '("\\`#" "\\`\\.")
 dired-refresh-automatically t
 dired-show-ls-switches nil
 dired-trivial-filenames "\\`\\.\\.?\\'\\|\\`#"
 dired-unshar-program nil
 dired-use-file-transformers t
 dired-verify-modtimes t
 reporter-version "3.35"
 )