Re: [Gc] [PATCH] More typos.

Ivan Maidanski ivmai at mail.ru
Wed Jul 31 14:25:57 PDT 2013


Hi Ondrej,

Thank you. I've committed your patch with minor changes.

Regards, 
Ivan


Воскресенье, 21 июля 2013, 20:54 +02:00 от Ondřej Bílka <neleai at seznam.cz>:
> 
> Hi,
> 
> I improved my spellchecker a bit and it found several typos that I
> missed at first pass.
> 
> ---
>  darwin_stop_world.c        | 2 +-
>  doc/porting.html           | 2 +-
>  include/gc.h               | 2 +-
>  include/private/gc_priv.h  | 2 +-
>  include/private/gcconfig.h | 2 +-
>  mallocx.c                  | 4 ++--
>  mark.c                     | 2 +-
>  os_dep.c                   | 6 +++---
>  pthread_support.c          | 8 ++++----
>  win32_threads.c            | 4 ++--
>  10 files changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/darwin_stop_world.c b/darwin_stop_world.c
> index 11813d2..2c47af9 100644
> --- a/darwin_stop_world.c
> +++ b/darwin_stop_world.c
> @@ -101,7 +101,7 @@ GC_INNER ptr_t GC_FindTopOfStack(unsigned long stack_start)
>  #endif /* !GC_NO_THREADS_DISCOVERY */
>  
>  /* Use implicit threads registration (all task threads excluding the GC */
> -/* special ones are stoped and scanned).  Should be called before       */
> +/* special ones are stopped and scanned).  Should be called before      */
>  /* GC_INIT() (or, at least, before going multi-threaded).  Deprecated.  */
>  GC_API void GC_CALL GC_use_threads_discovery(void)
>  {
> diff --git a/doc/porting.html b/doc/porting.html
> index 1208f16..4819fd6 100644
> --- a/doc/porting.html
> +++ b/doc/porting.html
> @@ -212,7 +212,7 @@ from are copied to the stack.  Typically this can be done portably,
>  but on some platforms it may require assembly code, or just
>  tweaking of conditional compilation tests.
>  <P>
> -For GC7, if your platform supports <TT>getcontext()</tt>, then definining
> +For GC7, if your platform supports <TT>getcontext()</tt>, then defining
>  the macro <TT>UNIX_LIKE</tt> for your OS in <TT>gcconfig.h</tt>
>  (if it isn't defined there already) is likely to solve the problem.
>  otherwise, if you are using gcc, <TT>_builtin_unwind_init()</tt>
> diff --git a/include/gc.h b/include/gc.h
> index 5b7dae3..a3a13b9 100644
> --- a/include/gc.h
> +++ b/include/gc.h
> @@ -664,7 +664,7 @@ struct GC_prof_stats_s {
>  /* should pass the size of the buffer (of GC_prof_stats_s type) to fill */
>  /* in the values - this is for interoperability between different GC    */
>  /* versions, an old client could have fewer fields, and vice versa,     */
> -/* client could use newer gc.h (with more entires declared in the       */
> +/* client could use newer gc.h (with more entries declared in the       */
>  /* structure) than that of the linked libgc binary; in the latter case, */
>  /* unsupported (unknown) fields are filled in with -1.  Return the size */
>  /* (in bytes) of the filled in part of the structure (excluding all     */
> diff --git a/include/private/gc_priv.h b/include/private/gc_priv.h
> index 097522e..a6c6609 100644
> --- a/include/private/gc_priv.h
> +++ b/include/private/gc_priv.h
> @@ -1894,7 +1894,7 @@ GC_EXTERN void (*GC_print_heap_obj)(ptr_t p);
>  
>  GC_EXTERN GC_bool GC_have_errors; /* We saw a smashed or leaked object. */
>                                    /* Call error printing routine        */
> -                                  /* occasionally.  It is ok to read it */
> +                                  /* occasionally.  It is OK to read it */
>                                    /* without acquiring the lock.        */
>  
>  #define VERBOSE 2
> diff --git a/include/private/gcconfig.h b/include/private/gcconfig.h
> index bc4c8df..aa154ba 100644
> --- a/include/private/gcconfig.h
> +++ b/include/private/gcconfig.h
> @@ -1305,7 +1305,7 @@
>  #       endif
>  #       ifdef USE_I686_PREFETCH
>            /* FIXME: Thus should use __builtin_prefetch, but we'll leave that */
> -          /* for the next rtelease.                                          */
> +          /* for the next release.                                           */
>  #         define PREFETCH(x) \
>              __asm__ __volatile__ ("prefetchnta %0" : : "m"(*(char *)(x)))
>              /* Empirically prefetcht0 is much more effective at reducing     */
> diff --git a/mallocx.c b/mallocx.c
> index 5cb41a9..e71152d 100644
> --- a/mallocx.c
> +++ b/mallocx.c
> @@ -367,7 +367,7 @@ GC_API void GC_CALL GC_generic_malloc_many(size_t lb, int k, void **result)
>                  GC_release_mark_lock();
>                  LOCK();
>                  /* GC lock is needed for reclaim list access.   We      */
> -                /* must decrement fl_builder_count before reaquiring GC */
> +                /* must decrement fl_builder_count before reacquiring GC*/
>                  /* lock.  Hopefully this path is rare.                  */
>                }
>  #           endif
> @@ -465,7 +465,7 @@ GC_API void * GC_CALL GC_memalign(size_t align, size_t lb)
>      /* is a multiple of align.  That would be correct up to HBLKSIZE.      */
>      new_lb = lb + align - 1;
>      result = GC_malloc(new_lb);
> -            /* It is ok not to check result for NULL as in that case    */
> +            /* It is OK not to check result for NULL as in that case    */
>              /* GC_memalign returns NULL too since (0 + 0 % align) is 0. */
>      offset = (word)result % align;
>      if (offset != 0) {
> diff --git a/mark.c b/mark.c
> index 16ea236..a5cca7d 100644
> --- a/mark.c
> +++ b/mark.c
> @@ -1768,7 +1768,7 @@ STATIC void GC_push_marked(struct hblk *h, hdr *hhdr)
>  
>  #ifdef ENABLE_DISCLAIM
>  /* Unconditionally mark from all objects which have not been reclaimed. */
> -/* This is useful in order to retain pointes which are reachable from   */
> +/* This is useful in order to retain pointers which are reachable from  */
>  /* the disclaim notifiers.                                              */
>  /*                                                                      */
>  /* To determine whether an object has been reclaimed, we require that   */
> diff --git a/os_dep.c b/os_dep.c
> index 738ca25..9a91c34 100644
> --- a/os_dep.c
> +++ b/os_dep.c
> @@ -1083,7 +1083,7 @@ GC_INNER word GC_page_size = 0;
>            } /* Otherwise it's not safe to add 16 bytes and we fall      */
>              /* back to using /proc.                                     */
>  #       elif defined(SPARC)
> -          /* Older versions of glibc for 64-bit Sparc do not set
> +          /* Older versions of glibc for 64-bit SPARC do not set
>             * this variable correctly, it gets set to either zero
>             * or one.
>             */
> @@ -2308,7 +2308,7 @@ void * os2_alloc(size_t bytes)
>      {
>        while (GC_n_heap_bases-- > 0) {
>  #       ifdef CYGWIN32
> -          /* FIXME: Is it ok to use non-GC free() here? */
> +          /* FIXME: Is it OK to use non-GC free() here? */
>  #       else
>            GlobalFree(GC_heap_bases[GC_n_heap_bases]);
>  #       endif
> @@ -3914,7 +3914,7 @@ typedef enum {
>  #ifdef THREADS
>    /* FIXME: 1 and 2 seem to be safe to use in the msgh_id field,        */
>    /* but it isn't documented. Use the source and see if they            */
> -  /* should be ok.                                                      */
> +  /* should be OK.                                                      */
>  # define ID_STOP 1
>  # define ID_RESUME 2
>  
> diff --git a/pthread_support.c b/pthread_support.c
> index 876c2a6..0f16499 100644
> --- a/pthread_support.c
> +++ b/pthread_support.c
> @@ -146,7 +146,7 @@
>  #     define REAL_FUNC(f) GC_real_##f
>        /* We define both GC_f and plain f to be the wrapped function.    */
>        /* In that way plain calls work, as do calls from files that      */
> -      /* included gc.h, wich redefined f to GC_f.                       */
> +      /* included gc.h, which redefined f to GC_f.                      */
>        /* FIXME: Needs work for DARWIN and True64 (OSF1) */
>        typedef int (* GC_pthread_create_t)(pthread_t *,
>                                      GC_PTHREAD_CREATE_CONST pthread_attr_t *,
> @@ -675,7 +675,7 @@ STATIC void GC_remove_all_threads_but_me(void)
>            me = p;
>            p -> next = 0;
>  #         ifdef GC_DARWIN_THREADS
> -            /* Update thread Id after fork (it is ok to call    */
> +            /* Update thread Id after fork (it is OK to call    */
>              /* GC_destroy_thread_local and GC_free_internal     */
>              /* before update).                                  */
>              me -> stop_info.mach_thread = mach_thread_self();
> @@ -685,7 +685,7 @@ STATIC void GC_remove_all_threads_but_me(void)
>  #         if defined(THREAD_LOCAL_ALLOC) && !defined(USE_CUSTOM_SPECIFIC)
>              /* Some TLS implementations might be not fork-friendly, so  */
>              /* we re-assign thread-local pointer to 'tlfs' for safety   */
> -            /* instead of the assertion check (again, it is ok to call  */
> +            /* instead of the assertion check (again, it is OK to call  */
>              /* GC_destroy_thread_local and GC_free_internal before).    */
>              if (GC_setspecific(GC_thread_key, &me->tlfs) != 0)
>                ABORT("GC_setspecific failed (in child)");
> diff --git a/win32_threads.c b/win32_threads.c
> index 8439178..2d18dc3 100644
> --- a/win32_threads.c
> +++ b/win32_threads.c
> @@ -1047,7 +1047,7 @@ GC_API void * GC_CALL GC_call_with_gc_active(GC_fn_type fn,
>  
>  #     if defined(THREAD_LOCAL_ALLOC) && !defined(USE_CUSTOM_SPECIFIC)
>          /* For Cygwin, we need to re-assign thread-local pointer to     */
> -        /* 'tlfs' (it is ok to call GC_destroy_thread_local and         */
> +        /* 'tlfs' (it is OK to call GC_destroy_thread_local and         */
>          /* GC_free_internal before this action).                        */
>          if (GC_setspecific(GC_thread_key, &me->tlfs) != 0)
>            ABORT("GC_setspecific failed (in child)");
> @@ -2110,7 +2110,7 @@ GC_INNER void GC_get_next_stack(char *start, char *limit,
>        /* does not work because they are used with different checked     */
>        /* conditions in different places (and, in addition, notifying is */
>        /* done after leaving critical section) and this could result in  */
> -      /* a signal loosing between checking for a particular condition   */
> +      /* a signal losing between checking for a particular condition    */
>        /* and calling WaitForSingleObject.  So, we use PulseEvent() and  */
>        /* NT SignalObjectAndWait() (which atomically sets mutex event to */
>        /* signaled state and starts waiting on condvar).  A special      */
> --
> 1.8.3.2
> 
> _______________________________________________
> Gc mailing list
> Gc at linux.hpl.hp.com
> https://www.hpl.hp.com/hosted/linux/mail-archives/gc/

> 

Отправлено из мобильной Почты Mail.Ru



More information about the Gc mailing list